By name: review-pr description: Review a Fleet pull request for correctness, Go idioms, SQL safety, test coverage, and conventions. Use when asked to "review PR" or "review pull request". context: fork allowed-tools: Bash(gh *), Read, Grep, Glob model: opus effort: high
Review the pull request: $ARGUMENTS
Use gh pr view and gh pr diff to get the full context.
Review the changes focusing on:
- Correctness — logic errors, edge cases, nil pointer risks
- Go idioms — error handling with ctxerr, proper context usage, slog logging
- SQL safety — injection risks, missing indexes for new queries, migration correctness
- Test coverage — are new code paths tested? Are integration tests needed?
- Fleet conventions — matches patterns in surrounding code
For each issue found, cite the specific file and line. Categorize findings as:
- Must fix — bugs, security issues, data loss risks
- Should fix — convention violations, missing error handling
- Nit — style preferences, minor improvements
Be concise. Don't comment on things that are fine.