name: validate-extension description: Validate the implementation and support in lavatube for a given Vulkan extension metadata: short-description: Validate lavatube's support for a Vulkan extension
- Check that we were told which Vulkan extension we are supposed to check. If this was not specified, ask.
- Download the extension text from
https://docs.vulkan.org/refpages/latest/refpages/source/<extension name>.htmland read it. - For each new Vulkan command defined in the given extension, look for its generated implementation named
trace_<name>ingenerated/write_auto.cpp. Review it for errors, then compare it to the corresponding read function namedretrace_<name>ingenerated/read_auto.cpp. Verify that the serialized output is likely to be read back in correctly. If not found in generated code, they may have been hardcoded in code in thesrcdirectory instead. - For each new Vulkan structure defined in the given extension, look for its generated implementation named
write_<name>ingenerated/struct_write_auto.cpp. Review it for errors, then compare it to the corresponding read function namedread_<name>ingenerated/struct_read_auto.cpp. Verify that the serialized output is likely to be read back in correctly. If not found in generated code, they may have been hardcoded in thesrc/hardcode_*.cppfiles instead. - Check if any new object types are defined in the given extension. If so, look at the Vulkan creation
command for the object type, and see if there is any metadata there we should be tracking. If so, that
should be in
src/lavatube.hunder its correspondingtrackablechild class. The trackable class is typically named the same as the object type but in all lower case and itsvkprefix replaced withtracked. - Check if the extension has been promoted to core (e.g. "Promotion to Vulkan 1.3"). If it has been promoted, and we have any hardcoded functions, check if these also have core equivalents (ie function name without the extension suffix). Warn if these are missing. Check also if there are hardcoded core functions that are missing extension variants.
- If the extension adds support for any new SPIRV opcodes, check if these are handled by the spirv-simulator
in
external/spirv-simulator/framework/spirv_simulator.cpp. - Check if there are any tests in either our
testsdirectory or inexternal/tracetoolteststhat use this extension. Make a short note if no tests were found.